[PATCH] D136925: [clangd] Index unscoped enums inside classes for code completion

Nathan Ridge via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Wed Nov 2 01:35:49 PDT 2022


nridge accepted this revision.
nridge added a comment.
This revision is now accepted and ready to land.

Thanks!

I don't think we need this much detail in the commit message; I think after the first line it would be sufficient to say:

  Fixes https://github.com/clangd/clangd/issues/1082
  See the issue for disk/memory usage measurements

(Note also that "Fixes <issue>" triggers the github issue to be closed when the commit is merged.)

I forget whether you have commit access -- let me know if you need me to merge the patch for you.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D136925/new/

https://reviews.llvm.org/D136925



More information about the cfe-commits mailing list