[PATCH] D137180: [LinkerWrapper] report on missing libraries

[Johannes Doerfert via Phabricator via cfe-commits]

jdoerfert added inline comments.


================
Comment at: clang/tools/clang-linker-wrapper/ClangLinkerWrapper.cpp:1278
+      if (identify_magic((*BufferOrErr)->getBuffer()) != file_magic::archive)
+        continue;
+
----------------
jhuber6 wrote:
> jdoerfert wrote:
> > So if the library is found but not an archive we silently continue still?
> In that case it won't be used for device linking so the host linker will handle that.
Can you add a comment, I still don't understand when/how this happens but a comment might do.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D137180/new/

https://reviews.llvm.org/D137180