[PATCH] D136975: [Concepts] Correctly handle failure when checking concepts recursively

Tue Nov 1 11:01:58 PDT 2022

erichkeane added a comment.

In D136975#3899703 <https://reviews.llvm.org/D136975#3899703>, @ychen wrote:

> Thanks for the patch. It looks good to me.
>
> About
>
>> Note that we DO need to be careful to make sure we still check
>> constraints properly that are caused by a previous constraint, but not
>> derived from (such as when a check causes us to check special member
>> function generation), so we cannot use the existing logic to see if this
>> is being instantiated.
>
> For the `derived from` case, I think we also end up getting the infinite recursion? Why do we disable the check for the `derived from` case?

Can you clarify what you mean?  I'm not sure which test case you're speaking of.

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D136975/new/

https://reviews.llvm.org/D136975