[PATCH] D135220: [clang] Update ModuleMap::getModuleMapFile* to use FileEntryRef

Duncan P. N. Exon Smith via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Tue Nov 1 10:48:06 PDT 2022


dexonsmith added a comment.

In D135220#3898849 <https://reviews.llvm.org/D135220#3898849>, @hans wrote:

> Relatedly, we ran into a problem with `clang-cl /showIncludes` not including all files in its output when they're linked: https://github.com/llvm/llvm-project/issues/58726

Interestingly, that discussion points out that `-MD` works correctly:

  $ clang -MD -c /tmp/a.cc && cat a.d     
  a.o: /tmp/a.cc /tmp/foo.h /tmp/bar.h

I presume this is because we've pushed FileEntryRef through dependency tracking. Just need to push it through more places, I think.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D135220/new/

https://reviews.llvm.org/D135220



More information about the cfe-commits mailing list