[PATCH] D82562: Implement AVX ABI Warning/error

[Jake Li via Phabricator via cfe-commits]

jajadude added a comment.
Herald added subscribers: StephenFan, pengfei.
Herald added a project: All.

   if (Callee->getReturnType()->isVectorType() && CGM.getContext().getTypeSize(Callee->getReturnType()) > 128) {
  }

I think this condition will make features like ext_vector_type to be warnings too?

e.g. Apple's <simd/simd.h> provides
`typedef __attribute__((__ext_vector_type__(3),__aligned__(16))) double simd_double3;`

It's a vector of 3*64= 192 bits, larger than 128



================
Comment at: clang/lib/CodeGen/TargetInfo.cpp:2566
+  if (Callee->getReturnType()->isVectorType() &&
+      CGM.getContext().getTypeSize(Callee->getReturnType()) > 128) {
+    initFeatureMaps(CGM.getContext(), CallerMap, Caller, CalleeMap, Callee);
----------------
I think this condition will make features like [ext_vector_type](https://clang.llvm.org/docs/LanguageExtensions.html#vectors-and-extended-vectors) to be warnings too?

e.g.  Apple's `<simd/simd.h>` provides
`typedef __attribute__((__ext_vector_type__(3),__aligned__(16))) double simd_double3;`

It's a vector of 3*64= 192 bits, larger than 128


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D82562/new/

https://reviews.llvm.org/D82562