[clang] 6fa0e3d - [X86][Driver] Remove stale FIXME. NFC
Craig Topper via cfe-commits
cfe-commits at lists.llvm.org
Mon Oct 31 10:41:52 PDT 2022
Author: Craig Topper
Date: 2022-10-31T10:41:40-07:00
New Revision: 6fa0e3df97ac1280da98bd1bc156dad5e036246b
URL: https://github.com/llvm/llvm-project/commit/6fa0e3df97ac1280da98bd1bc156dad5e036246b
DIFF: https://github.com/llvm/llvm-project/commit/6fa0e3df97ac1280da98bd1bc156dad5e036246b.diff
LOG: [X86][Driver] Remove stale FIXME. NFC
We use getHostCPUFeatures in x86::getX86TargetFeatures so I think
this FIXME is taken care of already.
Reviewed By: RKSimon
Differential Revision: https://reviews.llvm.org/D137054
Added:
Modified:
clang/lib/Driver/ToolChains/Arch/X86.cpp
Removed:
################################################################################
diff --git a/clang/lib/Driver/ToolChains/Arch/X86.cpp b/clang/lib/Driver/ToolChains/Arch/X86.cpp
index 81cccb6d11478..d847db7018252 100644
--- a/clang/lib/Driver/ToolChains/Arch/X86.cpp
+++ b/clang/lib/Driver/ToolChains/Arch/X86.cpp
@@ -30,9 +30,6 @@ std::string x86::getX86TargetCPU(const Driver &D, const ArgList &Args,
// FIXME: Reject attempts to use -march=native unless the target matches
// the host.
- //
- // FIXME: We should also incorporate the detected target features for use
- // with -native.
CPU = llvm::sys::getHostCPUName();
if (!CPU.empty() && CPU != "generic")
return std::string(CPU);
More information about the cfe-commits
mailing list