[PATCH] D134410: [clang][CodeGen] Add noundef metadata to load instructions (preliminary 1 or 2)

John McIver via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Mon Oct 31 10:14:25 PDT 2022


jmciver added inline comments.


================
Comment at: clang/lib/CodeGen/CGExpr.cpp:676
+namespace {
+void applyNoundefToLoadInst(bool enable, const clang::QualType &Ty,
+                            llvm::LoadInst *Load) {
----------------
tschuett wrote:
> Nit: You meant static.
Thank you for bringing that to my attention. I reviewed the [[ https://llvm.org/docs/CodingStandards.html#anonymous-namespaces | LLVM Coding Standards ]] guidance on the topic.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D134410/new/

https://reviews.llvm.org/D134410



More information about the cfe-commits mailing list