[PATCH] D137067: [DebugInfo][Metadata] Make AllEnumTypes holding TrackingMDNodeRef

David Blaikie via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Mon Oct 31 08:02:44 PDT 2022


dblaikie accepted this revision.
dblaikie added a comment.
This revision is now accepted and ready to land.

Test case can be simplified a bit further:

  template <typename> struct Struct1 {
    enum { enumValue1 };
    Struct1();
  };
  void function2() {
    struct Struct3 {};
    int i = Struct1<Struct3>::enumValue1;
  }
  void function3() {
    struct Struct3 {};
    int i = Struct1<Struct3>::enumValue1;
  }

but otherwise I'm OK with this - I don't /fully/ understand it, but it sounds plausible enough. (if you have time, I wouldn't mind hearing more about why this requires local types (`Struct3`) and two similar functions to tickle the issue)


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D137067/new/

https://reviews.llvm.org/D137067



More information about the cfe-commits mailing list