[PATCH] D136953: [C++20] Diagnose invalid and reserved module names

Aaron Ballman via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Mon Oct 31 06:47:27 PDT 2022


aaron.ballman updated this revision to Diff 471988.
aaron.ballman marked 2 inline comments as done.
aaron.ballman added a comment.

Updated based on review feedback:

- Fixed a typo
- Clarified the release note
- Added a test case for `std.foo` being reserved


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D136953/new/

https://reviews.llvm.org/D136953

Files:
  clang/docs/ReleaseNotes.rst
  clang/include/clang/Basic/DiagnosticSemaKinds.td
  clang/lib/Sema/SemaModule.cpp
  clang/test/CodeGenCXX/cxx20-module-std-subst-1.cppm
  clang/test/Modules/pair-unambiguous-ctor.cppm
  clang/test/Modules/reserved-names-1.cpp
  clang/test/Modules/reserved-names-2.cpp
  clang/test/Modules/reserved-names-3.cpp
  clang/test/Modules/reserved-names-system-header-1.cpp
  clang/test/Modules/reserved-names-system-header-2.cpp

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D136953.471988.patch
Type: text/x-patch
Size: 11217 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/cfe-commits/attachments/20221031/ff728e46/attachment.bin>


More information about the cfe-commits mailing list