[PATCH] D137063: [clangd] Run semantic highligting in clangd check.

[Kadir Cetinkaya via Phabricator via cfe-commits]

kadircet accepted this revision.
kadircet added a comment.
This revision is now accepted and ready to land.

thanks!



================
Comment at: clang-tools-extra/clangd/tool/Check.cpp:213
+    auto Highlights = getSemanticHighlightings(*AST);
+    if (LineRange) {
+      for (const auto HL : Highlights) {
----------------
we should print all the highlights when LineRange is missing. so maybe turn this into:
```
auto Highlights = ...
for(const auto HL : ..) {
  if(!LineRange || LineRange->contains(HL.R))
     vlog(...);
}
```


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D137063/new/

https://reviews.llvm.org/D137063