[PATCH] D136951: [clangd] Populate ranges and symbol origin for paramname completions
    Haojian Wu via Phabricator via cfe-commits 
    cfe-commits at lists.llvm.org
       
    Mon Oct 31 02:33:39 PDT 2022
    
    
  
hokein accepted this revision.
hokein added inline comments.
This revision is now accepted and ready to land.
================
Comment at: clang-tools-extra/clangd/CodeComplete.cpp:2019
+  // Point back to cursor location.
+  Offset += 2;
+  CompletionRange.start = offsetToPosition(ParseInput.Contents, Offset);
----------------
nit: I think  a comment `// skip /*` is clearer.
Repository:
  rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D136951/new/
https://reviews.llvm.org/D136951
    
    
More information about the cfe-commits
mailing list