[PATCH] D135858: [clang][Interp] Support pointer arithmetic in binary operators
Timm Bäder via Phabricator via cfe-commits
cfe-commits at lists.llvm.org
Fri Oct 28 21:28:53 PDT 2022
tbaeder added inline comments.
================
Comment at: clang/lib/AST/Interp/Interp.h:970
+ if (!Pointer::hasSameArray(LHS, RHS)) {
+ // TODO: Diagnose.
+ return false;
----------------
shafik wrote:
> tbaeder wrote:
> > This is also not being diagnosed (only rejected) by the current interpreter. But would be nice to have an error message.
> The TODO is still present, will you tackle this as part of this PR or a follow-up?
A follow-up would be better I think.
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D135858/new/
https://reviews.llvm.org/D135858
More information about the cfe-commits
mailing list