[PATCH] D136533: [clang] Fix missing diagnostic of declaration use when accessing TypeDecls through typename access

[Louis Dionne via Phabricator via cfe-commits]

ldionne added a comment.

Ah, I understand. Thanks for explaining and sorry, I had only taken a quick look.

So -- the reason why this isn't found by the libc++ CI is that it only triggers when we build on macOS, and our CI does not perform a bootstrapping build on macOS. In other words, we're never using your new modified Clang to run our tests on macOS in the libc++ CI.

Regarding the bug itself, I am not sure I understand why this is triggering because the `path` class itself *is* marked as unavailable, which means that all of its methods should be marked as unavailable. I'll have to pull your patch down, build my Clang and play around with that.

In terms of the next steps:

1. I'll figure out what's wrong with libc++ and if it's indeed a bug in libc++. If so, I'll fix it ASAP.
2. Shipping this change does mean that anyone building anything with a new Clang and a not-yet-updated libc++ with a deployment target before 10.15 (or whatever first version we shipped filesystem in) will fail. IMO that's kind of annoying, but may be OK if we fix libc++ first.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D136533/new/

https://reviews.llvm.org/D136533