[PATCH] D136959: clang: Improve errors for DiagnosticInfoResourceLimit

[Arthur Eubanks via Phabricator via cfe-commits]

aeubanks added a comment.

see https://reviews.llvm.org/D110665 for how we get line/col from a function. basically, we have a map from function name hashes to source location available in clang

if we don't have clang source information for functions available, there's not much more we can do other than rely on debug info, which is what the default LLVM handlers use when possible. that's why lld doesn't have its own handler

> Backend errors are not observed with -save-temps and -fno-gpu-rdc or -flto, and the compile incorrectly succeeds.

not sure why this would be happening



================
Comment at: clang/include/clang/Basic/DiagnosticFrontendKinds.td:42
+def note_fe_backend_resource_limit: Note<"%0 (%1) exceeds limit (%2) in '%3'">, BackendInfo;
+
+
----------------
ultra nit: extra blank line


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D136959/new/

https://reviews.llvm.org/D136959