[PATCH] D133052: [clang] Avoid crash when expanding conversion templates in concepts.

Utkarsh Saxena via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Fri Oct 28 11:03:38 PDT 2022


usaxena95 added a comment.

Coincidentally 2 of the bugs were just fixed in b9a77b56d8 <https://github.com/llvm/llvm-project/commit/b9a77b56d83ac788beb7b1743e510ef8534354ca>. I do not completely agree with the approach there though. We should be fixing the root cause instead of circumventing the assert in `InsertNode` by insert-if-not-present. This is why we still have 44304 and 50891 still persistent.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D133052/new/

https://reviews.llvm.org/D133052



More information about the cfe-commits mailing list