[PATCH] D136872: [OpenMP][OpenMPIRBuilder] Migrate loadOffloadInfoMetadata from clang to OMPIRbuilder

[Johannes Doerfert via Phabricator via cfe-commits]

jdoerfert added a comment.

@jsjodin Can you take a look and accept once it looks ok.



================
Comment at: llvm/lib/Frontend/OpenMP/OMPIRBuilder.cpp:4717
+  if (!isDevice)
+    return;
+
----------------
TIFitis wrote:
> jdoerfert wrote:
> > Why do we call it if isDevice is false? Module should be available to the IRBuilder.
> loadOffloadInfoMetadata is called from clang with a different Module generated using parseBitcodeFile. I've checked that the module available from OMPIRBuilder and the one passed by clang are different and cause errors.
I see. Then document this explicitly in the doxygen comment of the declaration, please. Also check isDevice at the call site.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D136872/new/

https://reviews.llvm.org/D136872