[PATCH] D136385: Add support for MC/DC in LLVM Source-Based Code Coverage

Alan Phipps via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Fri Oct 28 09:24:46 PDT 2022


alanphipps added a comment.

Thank you (both) for looking at it! I appreciate your time.

In D136385#3891311 <https://reviews.llvm.org/D136385#3891311>, @peter.smith wrote:

> I suspect that this patch will need to get split up into smaller parts. While it is very useful to see everything at once, it may be better to use this as a kind of support for the RFC, and then split off the implementation into smaller independently reviewable parts, even if the full functionality isn't useable until the last patch lands. For example the LLVM changes could be looked at and accepted prior to clang.

I agree -- I will explore splitting the review up, probably next week.  And I'll review the suggested adjustments.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D136385/new/

https://reviews.llvm.org/D136385



More information about the cfe-commits mailing list