[PATCH] D136942: [C2x] Add test coverage for WG14 N2322
Aaron Ballman via Phabricator via cfe-commits
cfe-commits at lists.llvm.org
Fri Oct 28 07:59:15 PDT 2022
aaron.ballman added inline comments.
================
Comment at: clang/test/C/C2x/n2322.c:44
+ ) == 2007);
+}
+
----------------
erichkeane wrote:
> I might suggest:
>
> _Static_assert(555 == __\
> LI\
> NE\
> __)
>
> Which, is basically exactly what the first bullet point in J.1 is trying to figure out (it should be the opening character).
>
> I think this is a repeat of the string-literal test, but it is basically exactly what they were talking about with PP-token.
>
> Not a great addition to this file perhaps, but something with #warning might be a nice exercise of the pp-directive, to make sure it hits the diagnostics engine right?
>
>
I've added the test.
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D136942/new/
https://reviews.llvm.org/D136942
More information about the cfe-commits
mailing list