[PATCH] D136886: [clang] [ASTImporter] RFC: Correct importer to not duplicate sugared types
Matheus Izvekov via Phabricator via cfe-commits
cfe-commits at lists.llvm.org
Fri Oct 28 07:40:17 PDT 2022
mizvekov added a comment.
I agree having two different val_list types is suspect, it might not have been imported and is simply referring to the va_list of the original context.
One other note, is that if a problem exists for TypedefType, it probably exists for UsingType as well, as they are very closely related.
The one difference is that TypedefType still uses the TypeDecl scheme of uniquing, instead of using a FoldingSet as UsingType does, and the former is a bit unfriendly to the ASTImporter/ASTReader as there is a cycle there, the Decl holds a reference to the type and vice versa.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D136886/new/
https://reviews.llvm.org/D136886
More information about the cfe-commits
mailing list