[PATCH] D136694: [clang][Interp] Check that constructor calls initialize all record fields

Timm Bäder via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Fri Oct 28 06:01:34 PDT 2022


tbaeder added inline comments.


================
Comment at: clang/lib/AST/Interp/Interp.cpp:465
+bool CheckCtorCall(InterpState &S, CodePtr OpPC, const Pointer &This) {
+  assert(!This.isZero());
+  const Record *R = This.getRecord();
----------------
shafik wrote:
> Should we also check `isLive()` or should that just turn into a diagnostic?
Since cc79ddb52c310be50d2ed0e0307b695cc7c142ce, we use `CheckInvoke()` for the instance pointer, which already calls `isLive()`.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D136694/new/

https://reviews.llvm.org/D136694



More information about the cfe-commits mailing list