[PATCH] D136436: [Clang][LoongArch] Add register alias handling without `$` prefix

Thu Oct 27 22:36:35 PDT 2022

SixWeining added a comment.

In D136436#3881382 <https://reviews.llvm.org/D136436#3881382>, @MaskRay wrote:

> In D136436#3876684 <https://reviews.llvm.org/D136436#3876684>, @SixWeining wrote:
>
>> In D136436#3873987 <https://reviews.llvm.org/D136436#3873987>, @xen0n wrote:
>>
>>> In D136436#3873949 <https://reviews.llvm.org/D136436#3873949>, @SixWeining wrote:
>>>
>>>> How about the asm code in `.s`? Do we need to support `addi.d a0, a1, a2`?
>>>
>>> For the assembler part of this support, I think we need to coordinate with the GNU toolchain maintainers of LoongArch port (Chenghua, Zhensong and Lulu I think). Maybe raising an issue on the LoongArch documentation repo <https://github.com/loongson/LoongArch-Documentation> would help.
>>>
>>> For the GCC part, consistency is of course welcomed, and I think the Loongson maintainers or @xry111 could just submit the respective support.
>>
>> Well. To be honest, I'd like to keep only one form but not both. Seems other archs only support one form? If we support both, will it make people confused?  Is mixed form allowed (`fmadd.d fa0, $fa0, f0, $fcc0`) ?
>
> Having just one form will be nice.

@tangyouling Considering that `$`  is well supported by both gcc and llvm, we should adandon this patch?

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D136436/new/

https://reviews.llvm.org/D136436