[PATCH] D136601: [OpenMP] [OMPIRBuilder] Create a new datatype to hold the unique target region info

Thu Oct 27 18:14:08 PDT 2022

jsjodin added inline comments.

================
Comment at: clang/lib/CodeGen/CGOpenMPRuntime.cpp:3031
+        OrderedEntries[E.getOrder()] =
+            std::make_tuple(&E, Loc, EntryInfo.ParentName);
+        ParentFunctions[E.getOrder()] = EntryInfo.ParentName;
----------------
mikerice wrote:
> vitalybuka wrote:
> > mikerice wrote:
> > > Needed StringRef(EntryInfo.ParentName) for this to compile for me.
> > StringRef(EntryInfo.ParentName) is ref to the scope-local EntryInfo info, so you have HWASAN report here
> Probably meant to change this to const llvm::TargetRegionEntryInfo &EntryInfo to match OffloadTargetRegionEntryInfoActTy?
Yes, I think there was an inconsistency introduced when I was splitting up my patch. I will work on a fix.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D136601/new/

https://reviews.llvm.org/D136601