[PATCH] D136888: Move getenv for AS_SECURE_LOG_FILE to clang

[Steven Wu via Phabricator via cfe-commits]

steven_wu added a comment.

If we have to fix it, I slightly prefer just give it a proper option in CodeGenOption and a `cc1` and `cc1as` flag.



================
Comment at: llvm/lib/MC/MCContext.cpp:62
 
-static cl::opt<char*>
+static cl::opt<std::string>
 AsSecureLogFileName("as-secure-log-file-name",
----------------
benlangmuir wrote:
> Interestingly, `opt<char*>` doesn't have a parser; this code only worked with the default value before.
ha, maybe we should just deprecate the directive since this hasn't been working for more than 6 years!


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D136888/new/

https://reviews.llvm.org/D136888