[PATCH] D136797: [clang-tidy] Skip template ctors in modernize-use-equals-default

Alexander Shaposhnikov via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Thu Oct 27 15:09:40 PDT 2022


alexander-shaposhnikov marked 3 inline comments as done.
alexander-shaposhnikov added inline comments.


================
Comment at: clang-tools-extra/clang-tidy/modernize/UseEqualsDefaultCheck.cpp:249
                     unless(isVariadic()), parameterCountIs(0),
+                    unless(hasParent(functionTemplateDecl())),
                     IsPublicOrOutOfLineUntilCPP20),
----------------
ymandel wrote:
> since this appears in both branches, can you place it above on line 244? that will also save a `hasParent` call (fwiw).
> ```
> unless(hasParent(anyOf(IsUnionLikeClass, functionTemplateDecl())))
> ```
(changed to anyOf(hasParent(...)) (hasParent(anyOf(...)) doesn't compile))


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D136797/new/

https://reviews.llvm.org/D136797



More information about the cfe-commits mailing list