[PATCH] D136776: [clang codegen] Fix try/finally blocks in C++ constructors.

Thu Oct 27 12:16:22 PDT 2022

rnk accepted this revision.
rnk added a comment.
This revision is now accepted and ready to land.

>From what I know, we could always build the GlobalDecl with the base ctor/dtor variant. The complete and deleting variants always delegate to the base variants, and we will only ever emit the SEH funclets during emission of the base variant (`?0` and `?1`), but this seems like a perfectly fine solution.

lgtm

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D136776/new/

https://reviews.llvm.org/D136776

[PATCH] D136776: [clang codegen] Fix __try/__finally blocks in C++ constructors.

[PATCH] D136776: [clang codegen] Fix try/finally blocks in C++ constructors.