[PATCH] D136872: [OpenMP][OpenMPIRBuilder] Migrate loadOffloadInfoMetadata from clang to OMPIRbuilder

[Johannes Doerfert via Phabricator via cfe-commits]

jdoerfert added inline comments.


================
Comment at: llvm/include/llvm/Frontend/OpenMP/OMPIRBuilder.h:2167
+    Module &M, llvm::OffloadEntriesInfoManager &OffloadEntriesInfoManager,
+    bool isDevice);
+
----------------
Why is this in llvm namespace? This should be qualified further, e.g. part of the OMPIRBuilder. Also, no llvm::


================
Comment at: llvm/lib/Frontend/OpenMP/OMPIRBuilder.cpp:4717
+  if (!isDevice)
+    return;
+
----------------
Why do we call it if isDevice is false? Module should be available to the IRBuilder.


================
Comment at: llvm/lib/Frontend/OpenMP/OMPIRBuilder.cpp:4765
+  }
+}
+
----------------
No `llvm::`. Put `"omp_offload.info"` into a global constant, either in OMPIRBuilder or OMPConstants.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D136872/new/

https://reviews.llvm.org/D136872