[PATCH] D119051: Extend the C++03 definition of POD to include defaulted functions

Thu Oct 27 11:55:29 PDT 2022

rnk added a comment.

In D119051#3888906 <https://reviews.llvm.org/D119051#3888906>, @erichkeane wrote:

> I noticed in a downstream that this changes how we emit structs to IR sometimes (see https://godbolt.org/z/74xeq9rTj for an example, but the 'no-opaque-pointers' isn't necessary to cause this, just anything that causes emission of the struct).
>
> Are we OK with that?  Is the 'padding' arrays important in any way?

The actual layout is different, it now agrees with GCC, see:
https://godbolt.org/z/EK7Tb6YTT

This is actually a quite significant ABI change, and there are various mechanisms to stay on the old ABI.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D119051/new/

https://reviews.llvm.org/D119051