[PATCH] D136474: [CodeView][clang] Disable emitting command line into CodeView by default and add flag to enable

Nico Weber via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Thu Oct 27 11:33:34 PDT 2022


thakis added a comment.

> That works for me, I just want to make it clear that the long term goal for the project is that we emit the command line in LF_BUILDINFO by default, rather than disabling it once and for all. If it's not ready yet, great, let's disable it and continue.

Fully on board with this :)

> FWIW, we could probably move the terminal detection to the cc1 job. It inherits the TTY, right, so it can do the detection? I would look at how we handle fcolor-diagnostics here as reference, is that in the cc1 line or not?




Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D136474/new/

https://reviews.llvm.org/D136474



More information about the cfe-commits mailing list