[PATCH] D136807: [clang][Sema] Fix a clang crash with btf_type_tag

Yonghong Song via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Thu Oct 27 10:20:43 PDT 2022


yonghong-song added a comment.

In D136807#3888317 <https://reviews.llvm.org/D136807#3888317>, @aaron.ballman wrote:

> The changes generally look good to me, but can you add a release note for the fix as well?

Yes, will add the bug fix brief description to clang/docs/ReleaseNotes.rst



================
Comment at: clang/test/Sema/attr-btf_type_tag-func-ptr.c:1
+// RUN: %clang_cc1 -x c -triple x86_64-pc-linux-gnu -dwarf-version=4 -fsyntax-only -verify %s
+
----------------
aaron.ballman wrote:
> Does the dwarf version actually matter or can that be removed as well?
I will move the test to CodeGen directory and actually check dwarf output for btf_type_tag in debuginfo which will address David's suggestion as well.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D136807/new/

https://reviews.llvm.org/D136807



More information about the cfe-commits mailing list