[PATCH] D136854: [HIP] add -fhiplib-add-rpath

[Artem Belevich via Phabricator via cfe-commits]

tra added inline comments.


================
Comment at: clang/include/clang/Driver/Options.td:4156
   HelpText<"Do not add -rpath with architecture-specific resource directory to the linker flags">;
+def fhiplib_add_rpath: Flag<["-"], "fhiplib-add-rpath">, Flags<[NoArgumentUnused]>,
+  HelpText<"Add -rpath with HIP runtime library directory to the linker flags">;
----------------
This could be useful for CUDA, too. Perhaps it could use a more generic name like `-foffload-add-rpath` ?

I wonder if it should be just `--offload-add-rpath`, though given that we already using `-f` for the options with similar purpose, it would be OK, too.


================
Comment at: clang/include/clang/Driver/Options.td:4158
+  HelpText<"Add -rpath with HIP runtime library directory to the linker flags">;
+def fno_hiplib_add_rpath: Flag<["-"], "fno-hiplib-add-rpath">, Flags<[NoArgumentUnused]>,
+  HelpText<"Do not add -rpath with HIP runtime library directory to the linker flags">;
----------------
Any reason not to use `BoolFOption` instead of defining `-fno...` option separately?


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D136854/new/

https://reviews.llvm.org/D136854