[PATCH] D136782: [include-cleaner] Move the writeHTMLReport to the public header, NFC.

Sam McCall via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Thu Oct 27 06:59:45 PDT 2022


sammccall added a comment.

OOC, Is there something prompting doing this immediately?
I *did* originally plan to mechanically move this and we *can* but...

The API isn't even approximately the right shape (FileID should go away as we've baked main-file assumption in, Roots needs to be paired with macro refs, we need the includes and IWYU pragma stuff...). Then we have a function with a ton of parameters and there's probably some grouping that should go on.

So I'd be more inclined to let this sit for a couple of weeks and let the implementation catch up...


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D136782/new/

https://reviews.llvm.org/D136782



More information about the cfe-commits mailing list