[PATCH] D136474: [CodeView][clang] Disable emitting command line into CodeView by default and add flag to enable

Thu Oct 27 05:59:18 PDT 2022

thakis added a comment.

> I read that, and I'm indicating that I don't agree. Chromium's requirements are driven by its particular usage of a cross-compiling distributed build system, which may not represent the average user's needs.

Are you saying that it's a good thing if clang produces different output on different hosts?

> If you are still set on this course and don't want to try to address the determinism other ways, this flag seems fine to me, but I don't think it should be the default behavior. Does that provide a way forward?

I'm fine with not toggling the default in this patch. I'm a fan of doing one thing per patch anyways.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D136474/new/

https://reviews.llvm.org/D136474