[PATCH] D136796: [llvm-objdump][Offload] Use common offload extraction method

[James Henderson via Phabricator via cfe-commits]

jhenderson added a comment.

As a general rule, dumping tools should avoid hard errors, because usually they prevent the dumping tool from continuing to dump other useful and valid information as part of the same execution. I don't have a strong objection in this particular case, because I presume this error could be avoided by simply not dumping the offloading sections, but I wanted to make the context clear.



================
Comment at: llvm/lib/Object/OffloadBinary.cpp:261-263
+  case file_magic::elf_relocatable:
+  case file_magic::elf_executable:
+  case file_magic::elf_shared_object: {
----------------
Is there test code showing the ET_EXEC and ET_DYN objects work here?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D136796/new/

https://reviews.llvm.org/D136796