[PATCH] D135938: [X86] Add AVX-VNNI-INT8 instructions.

Wed Oct 26 22:34:46 PDT 2022

FreddyYe added inline comments.

================
Comment at: llvm/include/llvm/Support/X86TargetParser.def:205
 X86_FEATURE       (AVX512FP16,      "avx512fp16")
+X86_FEATURE       (AVXVNNIINT8,     "avxvnniint8")
 X86_FEATURE       (AVXVNNI,         "avxvnni")
----------------
skan wrote:
> Move it after AVXVNNI to keep the dictionary order?
Better refine at another patch since it's not ordered already

================
Comment at: llvm/lib/Target/X86/X86ISelLowering.h:592
+    VPDPBSSD,
+    VPDPBSSDS,
+
----------------
RKSimon wrote:
> Do we actually need these? Are you intending to add DAG combines for these?
Yes. A continued patch will support DAG combine like old VNNI instructions. https://reviews.llvm.org/D116039

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D135938/new/

https://reviews.llvm.org/D135938