[PATCH] D136776: [clang codegen] Fix __try/__finally blocks in C++ constructors.

Eli Friedman via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Wed Oct 26 11:36:40 PDT 2022


efriedma created this revision.
efriedma added reviewers: rjmccall, rnk, mstorsjo.
Herald added a project: All.
efriedma requested review of this revision.
Herald added a project: clang.

We were crashing trying to construct a GlobalDecl from a CXXConstructorDecl in the mangler.  Instead of trying to do that conversion, just pass down the original GlobalDecl.

The whole mangling scheme here doesn't really make sense to me, but I guess it doesn't really matter how we mangle these names as long as it doesn't crash.


Repository:
  rG LLVM Github Monorepo

https://reviews.llvm.org/D136776

Files:
  clang/include/clang/AST/Mangle.h
  clang/lib/AST/ItaniumMangle.cpp
  clang/lib/AST/MicrosoftMangle.cpp
  clang/lib/CodeGen/CGException.cpp
  clang/lib/CodeGen/CodeGenFunction.cpp
  clang/lib/CodeGen/CodeGenFunction.h
  clang/test/CodeGenCXX/exceptions-seh.cpp

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D136776.470886.patch
Type: text/x-patch
Size: 7875 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/cfe-commits/attachments/20221026/e20abadf/attachment-0001.bin>


More information about the cfe-commits mailing list