[PATCH] D136744: [Clang] perform "maximum TLS alignment" check for template instantiation

Yuanfang Chen via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Wed Oct 26 10:30:00 PDT 2022


ychen added inline comments.


================
Comment at: clang/lib/Sema/SemaDecl.cpp:14038-14039
+
+  if (!Context.getTargetInfo().isTLSSupported())
+    return;
+
----------------
mizvekov wrote:
> Is this needed? It seems `getMaxTLSAlign()` will return 0 in that case anyway.
It is checked in the other place where `err_tls_var_aligned_over_maximum` is used so I put it here. I'll remove the check here and there.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D136744/new/

https://reviews.llvm.org/D136744



More information about the cfe-commits mailing list