[PATCH] D136746: [mlir] Saturation arithmetic intrinsics

Tobias Gysi via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Wed Oct 26 04:24:58 PDT 2022


gysit added a comment.

Looks good from my side modulo the nit comment. Let's wait for @ftynse (the code owner) for the final approval.



================
Comment at: mlir/test/Target/LLVMIR/Import/intrinsic.ll:778
+declare i32 @llvm.usub.sat.i32(i32, i32)
+declare <8 x i32> @llvm.usub.sat.v8i32(<8 x i32>, <8 x i32>) #0
 declare token @llvm.coro.id(i32, i8* readnone, i8* nocapture readonly, i8*)
----------------
nit: the #0 seems unnecessary.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D136746/new/

https://reviews.llvm.org/D136746



More information about the cfe-commits mailing list