[PATCH] D136684: [clang][ASTImporter] Remove use of ParentMapContext.

Balázs Kéri via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Wed Oct 26 02:32:01 PDT 2022


balazske added a comment.

This is really a NFC-like change but not NFC because it has visible effects of removing some crashes. I could not produce a test that provokes the wrong case (when `getParents` returns an empty list). Is it enough to have no new test here? If we can get a test for the crash it needs more investigation to check if `RecursiveASTVisitor` works correct and probably a fix at other place.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D136684/new/

https://reviews.llvm.org/D136684



More information about the cfe-commits mailing list