[PATCH] D133698: [clang][dataflow] Implement transferBranch

[Gabor Marton via Phabricator via cfe-commits]

martong marked 9 inline comments as done.
martong added a comment.

Thanks for the assiduous review @ymandel !



================
Comment at: clang/lib/Analysis/FlowSensitive/TypeErasedDataflowAnalysis.cpp:78-79
 public:
-  TerminatorVisitor(const StmtToEnvMap &StmtToEnv, Environment &Env,
+  // The return type of the visit functions.
+  using RetTy = std::pair<const Expr *, bool>;
+  TerminatorVisitor(TypeErasedDataflowAnalysis &Analysis,
----------------
ymandel wrote:
> please lift this out and define it as a struct. then, refer to it by name on line 76.  that will improve the readability of the code and provide a way to document explicitly the role of the two fields.
Ok, I hoisted this to be `TerminatorVisitorRetTy`.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D133698/new/

https://reviews.llvm.org/D133698