[PATCH] D136336: [clang-format] Mark pragma region lines as StringLiterals

Wed Oct 26 00:13:48 PDT 2022

owenpan added inline comments.

================
Comment at: clang/lib/Format/TokenAnnotator.cpp:1345
       while (CurrentToken) {
-        if (IsMark || CurrentToken->Previous->is(TT_BinaryOperator))
+        if (IsMarkOrRegion || CurrentToken->Previous->is(TT_BinaryOperator)) {
           CurrentToken->setType(TT_ImplicitStringLiteral);
----------------
thieta wrote:
> HazardyKnusperkeks wrote:
> > This shouldn't be here. There is no closing brace for this, or am I missing something?
> No you are right it was a miss in the rebase. But it's fixed on main now. 
Probably caused by https://github.com/llvm/llvm-project/issues/58161, which was fixed in 37e754e5801c.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D136336/new/

https://reviews.llvm.org/D136336