[PATCH] D133874: [clang] Changes to produce sugared converted template arguments

Tue Oct 25 21:03:25 PDT 2022

glandium added a comment.

This broke building Firefox with:

  In file included from Unified_cpp_editor_txmgr0.cpp:2:
  In file included from /tmp/gecko/editor/txmgr/TransactionItem.cpp:6:
  In file included from /tmp/gecko/editor/txmgr/TransactionItem.h:9:
  In file included from /tmp/gecko/obj-x86_64-pc-linux-gnu/dist/include/nsCOMPtr.h:31:
  In file included from /tmp/gecko/obj-x86_64-pc-linux-gnu/dist/include/nsISupportsUtils.h:16:
  /tmp/gecko/obj-x86_64-pc-linux-gnu/dist/include/nsISupportsImpl.h:238:31: error: definition with same mangled name '_ZN27nsCycleCollectingAutoRefCnt4incrIXadL_Z25NS_CycleCollectorSuspect3EEEEmPvP28nsCycleCollectionParticipant' as another definition
    MOZ_ALWAYS_INLINE uintptr_t incr(void* aOwner,
                                ^
  /tmp/gecko/obj-x86_64-pc-linux-gnu/dist/include/nsISupportsImpl.h:238:31: note: previous definition is here
  /tmp/gecko/obj-x86_64-pc-linux-gnu/dist/include/nsISupportsImpl.h:266:31: error: definition with same mangled name '_ZN27nsCycleCollectingAutoRefCnt4decrIXadL_Z25NS_CycleCollectorSuspect3EEEEmPvP28nsCycleCollectionParticipantPb' as another definition
    MOZ_ALWAYS_INLINE uintptr_t decr(void* aOwner,
                                ^
  /tmp/gecko/obj-x86_64-pc-linux-gnu/dist/include/nsISupportsImpl.h:266:31: note: previous definition is here
  2 errors generated.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D133874/new/

https://reviews.llvm.org/D133874