[PATCH] D136715: formatting clang offloadbundler source file
Johannes Doerfert via Phabricator via cfe-commits
cfe-commits at lists.llvm.org
Tue Oct 25 16:57:24 PDT 2022
jdoerfert accepted this revision.
jdoerfert added a comment.
I'm not sure why you fight with phabricator so much. I was going to edit your revision metadata but you for some reason disallowed that.
I would generally suggest against that.
---
The patch itself is fine, the commit subject line and comment should be revisited though:
- Use an [NFC] tag and potentially an additional tag for the subcomponent, e.g., [Driver] or [OffloadBundler], to help people filter for relevant changes.
- The description should not duplicate the subject. Since this is a simple clang-format NFC patch, no description is necessary anyway.
Please address the above points before commiting the change.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D136715/new/
https://reviews.llvm.org/D136715
More information about the cfe-commits
mailing list