[PATCH] D136474: [CodeView][clang] Disable emitting command line into CodeView by default and add flag to enable

Tue Oct 25 14:29:38 PDT 2022

rnk added a comment.

In D136474#3883629 <https://reviews.llvm.org/D136474#3883629>, @thakis wrote:

> FWIW we do have precedent of deviating from cl.exe for determinism reasons. I think having deterministic output is a good default.

This is true, but the cc1 flag isn't inherently non-deterministic. I would prefer to fix the determinism bugs instead of adding flags and more divergence.

Can we use the `grecord-command-line` flag here instead of adding a new one?
https://clang.llvm.org/docs/ClangCommandLineReference.html#cmdoption-clang-grecord-command-line
I understand it has different semantics. We'd record the command line differently depending on whether codeview or DWARF is in use, and potentially both ways when both are in use (🙄 ).

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D136474/new/

https://reviews.llvm.org/D136474