[PATCH] D136638: [clang-doc] Fix typedef/using output.
Paul Kirth via Phabricator via cfe-commits
cfe-commits at lists.llvm.org
Tue Oct 25 13:40:17 PDT 2022
paulkirth accepted this revision.
paulkirth added a comment.
This revision is now accepted and ready to land.
LGTM.
================
Comment at: clang-tools-extra/clang-doc/BitcodeReader.cpp:396-397
+template <> llvm::Expected<CommentInfo *> getCommentInfo(TypedefInfo *I) {
+ I->Description.emplace_back();
+ return &I->Description.back();
+}
----------------
paulkirth wrote:
> nit: I know this is in the style of the rest of the file, but I believe that code was written before LLVM allowed C++17. I //think// we can just return the reference from `emplace_back()` directly, right?
oh, I didn't intend for you to update the whole file, just what was in your change, but thank you for the code clean up!
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D136638/new/
https://reviews.llvm.org/D136638
More information about the cfe-commits
mailing list