[PATCH] D123064: [Clang][C++23] P2071 Named universal character escapes

[Corentin Jabot via Phabricator via cfe-commits]

cor3ntin added inline comments.


================
Comment at: llvm/utils/UnicodeData/UnicodeNameMappingGenerator.cpp:46
+      auto SecondSemiPos = Line.find(';', FirstSemiPos + 1);
+      if (FirstSemiPos == std::string::npos)
+        continue;
----------------
RKSimon wrote:
> @cor3ntin Should this be SecondSemiPos ?
> 
> Report here: https://pvs-studio.com/en/blog/posts/cpp/1003/ (N39)
Yes. Nice catch.
There is no case of that happening in the file so it never manifested.
I'll push a commit fixing it.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D123064/new/

https://reviews.llvm.org/D123064