[PATCH] D136671: [analyzer] Fix crash for array-delete of UnknownVal values.

Balázs Benics via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Tue Oct 25 05:54:54 PDT 2022


steakhal added a comment.

In D136671#3882166 <https://reviews.llvm.org/D136671#3882166>, @isuckatcs wrote:

>> This eliminate the crash in `getDynamicElementCount` on that region
>
> I think that if the crash comes from `getDynamicElementCount`, we should address it there too, so 
> when the function is called elsewhere under the same circumstances it won't crash again.
>
> What do you think?

For me, it makes sense that `getDynamicElementCount()` is not intended to be called on a `null` MemRegion. So, from my point of view, the bug is at some callsite.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D136671/new/

https://reviews.llvm.org/D136671



More information about the cfe-commits mailing list