[PATCH] D136602: NFC: [clang] Template argument cleanups.
Nico Weber via Phabricator via cfe-commits
cfe-commits at lists.llvm.org
Tue Oct 25 05:39:08 PDT 2022
thakis added inline comments.
================
Comment at: clang-tools-extra/clang-tidy/modernize/UseTransparentFunctorsCheck.cpp:101
+ const TemplateArgument &Arg =
+ FunctorParentType->template_arguments()[ArgNum];
if (Arg.getKind() != TemplateArgument::Type)
----------------
This is overall a nice change, but here (and a few other places), the RHS looks strictly uglier to me. Maybe it makes sense to keep the getNumArgs() / getArg() functions (and make them call template_arguments() internally), for the cases where the code doesn't iterate over everything?
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D136602/new/
https://reviews.llvm.org/D136602
More information about the cfe-commits
mailing list