[PATCH] D129531: [clang][C++20] P0960R3: Allow initializing aggregates from a parenthesized list of values
Ilya Biryukov via Phabricator via cfe-commits
cfe-commits at lists.llvm.org
Tue Oct 25 02:41:48 PDT 2022
ilya-biryukov added inline comments.
================
Comment at: clang/lib/Serialization/ASTReaderStmt.cpp:2179
+ for (unsigned I = 0; I < E->NumExprs; I++)
+ E->getTrailingObjects<Expr *>()[I] = Record.readSubExpr();
+}
----------------
FYI: I think this is where the crash comes from.
We should allocate the trailing objects first.
E.g. see how `PragmaCommentDecl::CreateDeserialized` does this.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D129531/new/
https://reviews.llvm.org/D129531
More information about the cfe-commits
mailing list