[PATCH] D136385: Add support for MC/DC in LLVM Source-Based Code Coverage
Ellis Hoag via Phabricator via cfe-commits
cfe-commits at lists.llvm.org
Mon Oct 24 16:48:47 PDT 2022
ellis added inline comments.
================
Comment at: llvm/lib/ProfileData/InstrProfCorrelator.cpp:208
maybeSwap<IntPtrT>(CounterOffset),
+ maybeSwap<IntPtrT>(BitmaskOffset),
maybeSwap<IntPtrT>(FunctionPtr),
----------------
Since `BitmaskOffset` and `NumBitmaskBytes` are always zero, I would rather set them as zero here rather than passing in more parameters. See `ValuesPtr`.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D136385/new/
https://reviews.llvm.org/D136385
More information about the cfe-commits
mailing list