[PATCH] D136602: NFC: [clang] Template argument cleanups.

Mon Oct 24 12:25:48 PDT 2022

erichkeane accepted this revision.
erichkeane added a comment.
This revision is now accepted and ready to land.

LGTM once that one overload is removed (the non const one).  I'd rather we justify at that point WHY we need that overload in a separate review.

================
Comment at: clang/include/clang/AST/Type.h:5298

-  void Profile(llvm::FoldingSetNodeID &ID, const ASTContext &Context) {
-    Profile(ID, Context, getDeducedType(), getKeyword(), isDependentType(),
----------------
mizvekov wrote:
> erichkeane wrote:
> > What is happening here?
> There are implementation limitations here that don't allow us to use ArrayRef very well when it's element type is only forward declared, such as in this header.
Ah! That explains it, thanks!

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D136602/new/

https://reviews.llvm.org/D136602